feat(savings): add product performance metrics API (#470)#511
Merged
Devsol-01 merged 3 commits intoDevsol-01:mainfrom Mar 30, 2026
Merged
Conversation
- GET /savings/products/:id/metrics endpoint - Historical APY chart data with daily/weekly/monthly granularity - TVL growth over time from APY snapshots - User retention rate (active / total ever subscribed) - Sharpe ratio, APY volatility, min/max/avg risk metrics - Similar products comparison (same risk level) - 1-hour cache TTL via CacheInterceptor + cacheManager.set - ProductApySnapshot entity + migration 1795000000000 - ProductMetricsDto, ProductMetricsQueryDto, RiskMetricsDto DTOs - Graceful fallback to current product data when no snapshots exist
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Sendi0011 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(savings): Add Savings Product Performance Metrics API (#470)
Summary
Implements
GET /savings/products/:id/metrics— a comprehensive performance metrics endpoint for savings products, closing issue #470.What's changed
ProductApySnapshotentity + migration (1795000000000) — stores daily APY, TVL, and subscriber count snapshots per product for historical trend dataProductMetricsDto/ProductMetricsQueryDto/RiskMetricsDto— typed response and query DTOs with full Swagger annotationsSavingsService.getProductMetrics()— computes all metrics, groups snapshots by granularity, calculates Sharpe ratio and APY volatility, queries similar products by risk levelCacheInterceptor+CacheTTL(3600000)(1-hour TTL) and a manualcacheManager.setinside the service for the same keyAcceptance criteria coverage
Closes #470
Graceful fallback: when no snapshots exist yet (fresh product), the endpoint returns the current
interestRateandtvlAmountas a single data point rather than an empty array, so the frontend always has something to render.